- May 10, 2008
- Reaction score
- Dallas, TX
I wouldn't consider a PR tactless. Maybe annoying, if somebody sends you update after update for his PR and you barely have time to review it. But generally, a PR is a great opportunity to communicate. If you are maintainer, you can specify what you expect of the code, testers can give feedback about the improvements, etc. If people want to collaborate, the PR would be the last good chance to start with it. Sure, you can communicate earlier about what you plan. But nobody hates you for doing in the latest reasonable moment.
But generally, PRs are not more tactless than for example a draft for legislation. And like those, a PR rarely leaves "parliament" in the shape that it entered it.
I was talking more about the communication surrounding the pull request than the code changes that made up the content of the pull request. My point was, if the GitHub comment thread for a PR (with working code) began with something like the OP here, it wouldn't be very tactful, but at least the person making the PR would be contributing code that worked towards what they were proposing, which isn't as tactless as just saying "Adopt this proposal I've drawn up without demonstrating any inkling of how much effort might be required, or any ability or willingness to contribute to that effort".