Programming Question please help with cockpit buttons

[Mr Martian]

hey guys, i am trying to code a Virtual Cockpit that has a button which performs an animation. this is what i have so far in "clbkVCMouseEvent"

bool Pegasus::clbkVCMouseEvent (int id, int event, VECTOR3 &p)
{
	switch (id) 
	{
	case BUTTON_BAY1_OPEN:
			if (BAY_1Status < OPEN) BAY_1Status = OPENING;
		return true;
	case BUTTON_BAY1_CLOSE:
			if (BAY_1Status = OPEN) BAY_1Status = CLOSED;
		return true;



return true;
}
}

but the button only opens it, and does not close it :shrug: i know it's something really simple i'm doing wrong, but i don't know what... any help would be REALLY appreciated.

 

[orb]

There should be (BAY_1Status == OPEN) or (BAY_1Status > CLOSED). Otherwise you don't check if it's open but set it to open (single equals sign), and then immediately switch to CLOSED (only if OPEN carries a value different than 0).

If you want to make sure there is no similar error somewhere else, flip the order when you check conditions, i.e. "if (OPEN = BAY_1Status)" would cause an error.

Additionally, shouldn't the status be set to CLOSING instead of CLOSED?

But I don't know how you defined the BAY_1Status and how the status is tested for performing animation.

There may be actually no CLOSING in the enum at all, and what I said would cause a compiler error, or there may be also wrong condition checking when the animation is performed. I can't really tell, because I can't see the code.

 

[Mr Martian]

ah, i've got it working now thanks anyway, somehow this worked:

bool Pegasus::clbkVCMouseEvent (int id, int event, VECTOR3 &p)
{

BUTTON_BAY1_OPEN;
			if (BAY_1Status == CLOSED) BAY_1Status = OPENING;

BUTTON_BAY1_CLOSE;
			if (BAY_1Status == OPEN) BAY_1Status = CLOSING;

		return true;



return false;
}

figured that with just trial-and-error, thanks anyway for your help

 

[martins]

ah, i've got it working now thanks anyway, somehow this worked:
...
figured that with just trial-and-error, thanks anyway for your help

"Somehow it worked by trial and error" is not generally a unit testing strategy I would recommend. :blink:

Did you test for an opening request while the door is closing?