Question Implementing XRSound in Lua?

[JMW]

Well. So, any ideas how to play different songs for internal and external views for a Lua based vessel are welcome.

"Returns:<br>handle or nil handle to the current camera target (i.e. the object the camera is pointing at in external mode, or the handle of the vessel in cockpit mode)"
Could you use that? (I know zero about Lua!)

 

[misha.physics]

Could you use that?

Actually, I'm not sure.

 

[Gondos]

The Lua API is still missing a bunch of stuff, notably oapiCameraInternal which could help you now.

 

[misha.physics]

Thanks, it really can help. Is it implemented in Lua? Maybe I search it in the wrong place?:

 

[kuddel]

Adding missing API features to Lua is not that hard (as Open Orbiter now is ... open )
Whithout me being able to test this, adding oapiCameraInternal is just editing 2 files basically:
1. In LuaScript/LuaInterpreter/Interpreter.h (find the 'correct' place to put this - where the other 'camera' function definitions live)

// ...

    // Camera functions
    static int oapi_camera_internal (lua_State *L);
   // ...

2. In LuaScript/LuaInterpreter/Interpreter.cpp (In body of method LoadAPI) add the lookup:

void Interpreter::LoadAPI ()
{
  // ...

        // Camera functions
        {"camera_internal", oapi_camera_internal},

  // ...
}

...and further down (find the matching other camara-related functions) add the body and Documentation as well:

/***
Returns flag to indicate internal/external camera mode.

@function camera_internal
@treturn bool _true_ indicates an internal camera mode, i.e. the camera is
   located inside a vessel cockpit. In this case, the camera target is always
   the current focus object.
   _false_ indicates an external camera mode, i.e. the camera points toward an
   object from outside. The camera target may be a vessel, planet, spaceport,
   etc.
*/
int Interpreter::oapi_camera_internal (lua_State *L)
{
    lua_pushboolean (L, oapiCameraInternal() ? 1:0);
    return 1;
}

And of course: Test it!

All of the code above was just typed "in the blind", so there might by one or two syntax errors

 

[misha.physics]

Thanks. I could test this function in a Lua script, but maybe anyone who understands programming better than me (and can detect possible syntax errors) could edit and upload these Interpreter.h and Interpreter.cpp.

 

[kuddel]

My expertise in Lua is very low, but if you could write a Lua Test and add it to the automatic tests for Lua it would be very helpful.
In here: Script/Tests/GeneralApiTest.lua
It could be "commented out" in the first step, so as soon as somebody implements the feature (in C++) the test can immediately be enabled to check if it's working.
Even if you just post the Lua Script code here, would be a great help.

 

[misha.physics]

I rather meant that I can try to use oapiCameraInternal command in my Lua script, but I don't know how to write a Lua test file...

Is there an actual table that shows what the functions are released in Lua? Something like here:

Post in thread 'Orbiter BETA Lua development'

Oct 25, 2017

Another batch of vessel functions added.

A question to those who have experience in writing Lua C API (martin?):
Do you have any recommendation how to implement "reference types" (I mean structures that can be changed anytime and will immediately effect the Orbiter-Core.)
Like the BEACONLIGHTSPEC structure used with VESSEL::AddBeacon()
I think "metatables" and "__index" and all its voodoo ( ) is the way to go, but I don't feel I could do this at the moment...
A working (AddBeacon) C++ example would be perfect

---------- Post added 25-10-17 at 00:05 ---------- Previous post was...

• kuddel

But I don't see oapiCameraInternal here. Do I understand correctly that oapiCameraInternal is absent for now in Lua?

 

[Gondos]

Yes it is not implemented at the moment.

 

[kuddel]

As Gondos said: This feature is not (yet) available in Lua.

For whom it might concern, here's a little description:
All the API methods first only exists in "C++ Land".
For every C++ API method a "Translation" into "Lua Land" has to be implemented.
That Translation however has to be implemented in C++. Only after that, the specific functionality is available in "Lua Land".
See it as a dictionary that has all the words in french, but not all words have (yet) an english translation available