Orbiter-Forum  

Go Back   Orbiter-Forum > Projects > Site Support > Bug
Register Blogs Orbinauts List Social Groups FAQ Projects Mark Forums Read

Automatic link parsing and newline Issue Tools
issueid=450 06-25-2010 03:41 AM
Mostly harmless
Automatic link parsing and newline
The newline is ignored

When posting a link to known sites (OH, Wikipedia), and entering text below the link, using a newline character, the character is ignored and the text is posted on the right of the link:

http://orbiter-forum.com/showthread.php?t=16602

It doesn't happen for unknown sites
Issue Details
Project Site Support
Status Fixed
Priority 5 - Medium
Affected Version Unknown
Fixed Version (none)
Users able to reproduce bug 0
Users unable to reproduce bug 0
Assigned Users tblaxland
Tags (none)

06-25-2010 04:28 AM
Webmaster
 
Looking into it. It doesn't seem to eat all trailing whitespace, just newlines
Reply
06-25-2010 08:48 AM
orb orb is offline
O-F Administrator
Ninja
 
Only first newline is eaten. I noticed that too a while ago, but I'm used to click on Preview Post, and fix what's displayed not the way I wanted (I don't use WYSIWYG editor).

It's not only a case for AME hack, but also for eventtimer, [table] rows (table rows are usually parsed correctly, but sometimes they need double newlines, because only one can break the table - I need to find a rule for this, but I'm used to create tables with double newlines between rows, since I noticed that, so it's not an issue for me), and maybe something more (tags that remove "<br />" and other newlines from their body).
Reply
06-25-2010 10:43 AM
Webmaster
 
Thanks for the feedback, orb. The <br /> tags aren't being removed by the plugins (knowing the eventtimer, table and AME code reasonably well now...). It seems to be an issue with the parser trimming strings to/from the custom bb code functions. It doesn't occur on built-in bb codes. I notice that the actual post data still contains the newlines but a <br /> tag is just not generated in the html.
Reply
06-28-2010 08:12 AM
Webmaster
 
Fixed for eventTimer and AME (required setting "strip_space_after" option to zero for those tags).

For table tag, strip_space_after option is still on. No double newline is required after a table (or even between table rows) because the table is not displayed inline (at least that is how my browsers display it).

EDIT: example post HERE, for which the code looks like:
Code:
Testing some more:

[url="http://www.orbithangar.com/searchid.php?ID=2802"]Launch MFD - v 1.3.3 BETA for Orbiter 2010[/url]
Some text after

[url]http://www.orbithangar.com/searchid.php?ID=2802Some[/url] text after

[url="http://www.orbithangar.com/searchid.php?ID=2802"]Launch MFD - v 1.3.3 BETA for Orbiter 2010[/url]
Some text after

EDIT: [url="http://test.com/"]Test newline after stock bbcode[/url]
This text should be on new line.

EDIT2: [eventTimer]2009-12-01 17:10[/eventTimer]
Text on new line

EDIT3:
[TABLE]test table||
column 1|column 2|column 3
row|row|row your boat[/TABLE]
Text on new line

EDIT4: [url="http://www.orbithangar.com/searchid.php?ID=3165"]Attitude MFD V3.2[/url]
Text on new line
Reply
06-28-2010 11:43 AM
orb orb is offline
O-F Administrator
Ninja
 
I tested some tables, and my conclusion is that, it isn't a table tag that removes newlines between rows in some conditions, but some of additional formatting BB-code tags that are used inside a table. So, I'll keep creating all tables with double newlines, to not keep thinking whether I need somewhere a double newline, if I used a formatting, and to make the code of table clear to me this way.
Reply
06-29-2010 02:35 AM
Webmaster
 
Thanks for testing orb. The [right] and[list] tags that seem to be causing the problem there are internal vBulletin tags so I won't go messing with those.
Reply
Reply

Issue Tools
Subscribe to this issue

All times are GMT. The time now is 06:04 PM.

Quick Links Need Help?


About Us | Rules & Guidelines | TOS Policy | Privacy Policy

Orbiter-Forum is hosted at Orbithangar.com
Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2019, vBulletin Solutions Inc.
Copyright 2007 - 2017, Orbiter-Forum.com. All rights reserved.